Alessandro Ratti <[email protected]> writes: >> > For completeness you could also fixup: >> > >> > virtio_error(vdev, "%s: %d reason unknown", __func__, pnd->reason); >> > >> > for virtio-ballon. Otherwise: >> > >> > Reviewed-by: Alex Bennée <[email protected]> >> >> Thank you for your review. >> I've missed that. For completeness, I've sent out a v2 that removes the >> manual __func__ usage in virtio-balloon to avoid duplicate function names, >> as you suggested. > > Resending v2 with additional CCs to virtio maintainers and Michael > Tokarev (trivial-patches), as no feedback was received after initial > posting.
You should have added my Reviewed-by to the commit. You'll find tools like b4 can help you with this: https://qemu.readthedocs.io/en/v10.0.3/devel/submitting-a-patch.html#proper-use-of-reviewed-by-tags-can-aid-review > > Thank you for your time and consideration. > > Best regards, > Alessandro Ratti -- Alex Bennée Virtualisation Tech Lead @ Linaro
