On Fri, 3 Oct 2025 at 18:16, Richard Henderson
<[email protected]> wrote:
>
> Signed-off-by: Richard Henderson <[email protected]>
> ---
>  target/arm/cpregs.h            |  3 +++
>  target/arm/cpregs-gcs.c        | 15 +++++++++++++++
>  target/arm/tcg/translate-a64.c | 29 +++++++++++++++++++++++++++++
>  3 files changed, 47 insertions(+)


>  void define_gcs_cpregs(ARMCPU *cpu)
> diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c
> index 38a1f51ed5..4fb73f821b 100644
> --- a/target/arm/tcg/translate-a64.c
> +++ b/target/arm/tcg/translate-a64.c
> @@ -26,6 +26,7 @@
>  #include "cpregs.h"
>
>  static TCGv_i64 cpu_X[32];
> +static TCGv_i64 cpu_gcspr[32];

32 ?

>  static TCGv_i64 cpu_pc;



> +    for (i = 0; i < 4; i++) {
> +        cpu_gcspr[i] =
> +            tcg_global_mem_new_i64(tcg_env,
> +                                   offsetof(CPUARMState, cp15.gcspr_el[i]),
> +                                   gcspr_names[i]);
> +    }
>  }


We only initialize 4, so I assume that the array size
should be 4 as well.

Otherwise

Reviewed-by: Peter Maydell <[email protected]>

thanks
-- PMM

Reply via email to