On 10/2/25 9:39 AM, Shameer Kolothum wrote: > >> -----Original Message----- >> From: Jonathan Cameron <[email protected]> >> Sent: 01 October 2025 13:59 >> To: Shameer Kolothum <[email protected]> >> Cc: [email protected]; [email protected]; >> [email protected]; [email protected]; Jason Gunthorpe >> <[email protected]>; Nicolin Chen <[email protected]>; [email protected]; >> [email protected]; Nathan Chen <[email protected]>; Matt Ochs >> <[email protected]>; [email protected]; [email protected]; >> [email protected]; [email protected]; >> [email protected]; [email protected]; >> [email protected] >> Subject: Re: [PATCH v4 15/27] acpi/gpex: Fix PCI Express Slot Information >> function 0 returned value >> >> External email: Use caution opening links or attachments >> >> >> On Mon, 29 Sep 2025 14:36:31 +0100 >> Shameer Kolothum <[email protected]> wrote: >> >>> From: Eric Auger <[email protected]> >>> >>> At the moment we do not support other function than function 0. So >> according >>> to ACPI spec "_DSM (Device Specific Method)" description, bit 0 should >> rather >>> be 0, meaning no other function is supported than function 0. >>> >>> Signed-off-by: Eric Auger <[email protected]> >>> Signed-off-by: Shameer Kolothum <[email protected]> >> Given description, why not yank this to the front and get it upstreamed >> quicker. I agree with Jonathan, Can be sent in a prerequisite patch/series with potential updates in the ACPI table tests. Thanks Eric >> Also, a fixes tag seems appropriate? >> >> Doesn't this show up in some of the tables tests? > Possibly. I will double check that. > >> Please include relevant chunk of AML as well as qemu AML generation code >> isn't >> exactly easy to check against the spec. Probably +CC at least Michael >> Tsrikin >> on next version of this patch. > Ok. > > Thanks, > Shameer > > >> J >> >>> --- >>> hw/pci-host/gpex-acpi.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/hw/pci-host/gpex-acpi.c b/hw/pci-host/gpex-acpi.c >>> index 952a0ace19..4587baeb78 100644 >>> --- a/hw/pci-host/gpex-acpi.c >>> +++ b/hw/pci-host/gpex-acpi.c >>> @@ -64,7 +64,7 @@ static Aml *build_pci_host_bridge_dsm_method(void) >>> UUID = aml_touuid("E5C937D0-3553-4D7A-9117-EA4D19C3434D"); >>> ifctx = aml_if(aml_equal(aml_arg(0), UUID)); >>> ifctx1 = aml_if(aml_equal(aml_arg(2), aml_int(0))); >>> - uint8_t byte_list[1] = {1}; >>> + uint8_t byte_list[1] = {0}; >>> buf = aml_buffer(1, byte_list); >>> aml_append(ifctx1, aml_return(buf)); >>> aml_append(ifctx, ifctx1);
