Hi Philippe,
October 21, 2025 at 10:07 PM, "Philippe Mathieu-Daudé" wrote:
> On 19/10/25 17:15, Julian Ganz wrote:
> > @@ -531,21 +533,27 @@ try_deliver:
> > switch (cs->exception_index) {
> > case EXCP_PGM:
> > do_program_interrupt(env);
> > + qemu_plugin_vcpu_exception_cb(cs, last_pc);
> > break;
> > case EXCP_SVC:
> > do_svc_interrupt(env);
> > + qemu_plugin_vcpu_exception_cb(cs, last_pc);
> > break;
> > case EXCP_EXT:
> > do_ext_interrupt(env);
> > + qemu_plugin_vcpu_interrupt_cb(cs, last_pc);
> > break;
> > case EXCP_IO:
> > do_io_interrupt(env);
> > + qemu_plugin_vcpu_interrupt_cb(cs, last_pc);
> > break;
> > case EXCP_MCHK:
> > do_mchk_interrupt(env);
> > + qemu_plugin_vcpu_interrupt_cb(cs, last_pc);
> > break;
> > case EXCP_RESTART:
> > do_restart_interrupt(env);
> > + qemu_plugin_vcpu_interrupt_cb(cs, last_pc);
> > break;
> > case EXCP_STOP:
> > do_stop_interrupt(env);
> >
> Shouldn't we also track the STOP interrupt?
>
> qemu_plugin_vcpu_interrupt_cb(cs, last_pc);
>
> If not, please mention why in the patch description.
My expectation was that this exception is not observable in software
running on the target anyway, and that is would lead to a VCPU exit. For
which we already have qemu_plugin_register_vcpu_exit_cb. If I'm wrong
about that than we do want to also track STOP interrupts. If not I'll
add a sentence about that in the commit message.
Regards,
Julian
