Children are automatically unparented so manually unparenting is unnecessary.
Worse, automatic unparenting happens before the instance_finalize() callback of the parent gets called, so object_unparent() calls in the callback will refer to objects that are already unparented, which is semantically incorrect. Signed-off-by: Akihiko Odaki <[email protected]> --- See also: https://lore.kernel.org/qemu-devel/[email protected] --- hw/pci/shpc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/pci/shpc.c b/hw/pci/shpc.c index aac6f2d03459..938602866d77 100644 --- a/hw/pci/shpc.c +++ b/hw/pci/shpc.c @@ -735,7 +735,6 @@ void shpc_free(PCIDevice *d) if (!shpc) { return; } - object_unparent(OBJECT(&shpc->mmio)); g_free(shpc->config); g_free(shpc->cmask); g_free(shpc->wmask); --- base-commit: c85ba2d7a4056595166689890285105579db446a change-id: 20251027-shpc-d71bb72d67af Best regards, -- Akihiko Odaki <[email protected]>
