Hi Philippe,
Any comments for this series.
Thanks,
vishalc
On 25/10/25 10:49, Harsh Prateek Bora wrote:
Hi Philippe,
Thanks to you and others for valuable inputs on the series.
Should this be queued via your tree ?
Also, I see Daniel and Alistair had provided their R-bs on v3 of the
series, which were not retained possibly since the series had gone
through multiple iterations with significant improvements. I hope they
should be fine with their ack on finally approved series.
regards,
Harsh
On 10/24/25 18:35, Vishal Chourasia wrote:
Currently, when QEMU fails to load images (kernel, BIOS, initrd) via
load_image_targphys(), the error messages are not descriptive enough
for users to understand why the loading failed. This series adds the
ability to add Error information through the loader functions to
provide more detailed error reporting.
v10:
- Use size_to_str() to pretty print the maximum size allowed
information.
- Use size < 0 check instead of *errp
v9:
- Split Patch 2 from v8 into two patches.
- Included RB from Aditya Gupta.
v8:
- Rebased on latest master.
- Modified commit message for Patch 5.
v7:
- Dropped the patch [hw/ppc/spapr: Rename resize_hpt_err to errp].
already merged. Rebased on latest master.
v6:
- Pass error_fatal instead of errp where caller exits right after
load_image_targphys() fails.
- Include filename in error messages.
v5:
- Moved the patch which replaces open() with qemu_open() earlier in the
series.
- Incorporated minor changes in the error messages requested by Balaton.
- Moved check for size zero in load_image_targphys_as() into it's
separate patch.
v4:
- Reject empty files (`size == 0`) with an appropriate error. [1/5]
- Populate error when `rom_add_file_fixed_as()` fails. [1/5]
- Add missing check in hw/ppc/virtex_ml507.c [5/5]
- Fixed checkpatch warnings [5/5]
- Check errp for failures from
load_image_targphys/load_image_targphys_as [3,5/5]
- Remove unused variables [5/5]
v3:
- Use qemu_open() instead of open() in get_image_size() (danpb)
- Remove redundant error_setg_file_open() call (danpb)
- Use error_prepend()/error_reportf_err() to preserve underlying
error details (danpb)
[v9]:
https://lore.kernel.org/all/[email protected]
[v8]:
https://lore.kernel.org/all/[email protected]
[v7]:
https://lore.kernel.org/all/[email protected]
[v6]:
https://lore.kernel.org/qemu-devel/[email protected]
[v5]:
https://lore.kernel.org/all/[email protected]
[v4]:
https://lore.kernel.org/all/[email protected]
[v3]:
https://lore.kernel.org/all/[email protected]
[v2]:
https://lore.kernel.org/all/[email protected]
[v1]:
https://lore.kernel.org/all/[email protected]
Vishal Chourasia (6):
core/loader: Use qemu_open() instead of open() in get_image_size()
core/loader: capture Error from load_image_targphys
core/loader: improve error handling in image loading functions
core/loader: add check for zero size in load_image_targphys_as
core: Pass errp to load_image_targphys_as()
ppc: Pass error_fatal to load_image_targphys()
hw/alpha/dp264.c | 4 ++--
hw/arm/armv7m.c | 2 +-
hw/arm/boot.c | 5 +++--
hw/arm/digic_boards.c | 2 +-
hw/arm/highbank.c | 3 ++-
hw/arm/raspi.c | 2 +-
hw/arm/vexpress.c | 2 +-
hw/core/generic-loader.c | 5 +++--
hw/core/guest-loader.c | 4 ++--
hw/core/loader.c | 42 ++++++++++++++++++++++++++++------------
hw/hppa/machine.c | 5 +++--
hw/i386/multiboot.c | 2 +-
hw/i386/x86-common.c | 4 ++--
hw/ipmi/ipmi_bmc_sim.c | 2 +-
hw/loongarch/boot.c | 5 ++---
hw/m68k/an5206.c | 2 +-
hw/m68k/mcf5208.c | 4 ++--
hw/m68k/next-cube.c | 2 +-
hw/m68k/q800.c | 7 ++++---
hw/m68k/virt.c | 4 ++--
hw/microblaze/boot.c | 5 +++--
hw/mips/boston.c | 2 +-
hw/mips/fuloong2e.c | 9 +++++----
hw/mips/jazz.c | 2 +-
hw/mips/loongson3_virt.c | 10 ++++++----
hw/mips/malta.c | 9 +++++----
hw/nubus/nubus-device.c | 2 +-
hw/openrisc/boot.c | 5 +++--
hw/pci/pci.c | 2 +-
hw/ppc/amigaone.c | 13 ++-----------
hw/ppc/e500.c | 20 ++++---------------
hw/ppc/mac_newworld.c | 19 ++++++------------
hw/ppc/mac_oldworld.c | 19 ++++++------------
hw/ppc/pegasos2.c | 10 +++-------
hw/ppc/pnv.c | 27 ++++++--------------------
hw/ppc/ppc440_bamboo.c | 9 ++-------
hw/ppc/prep.c | 19 ++++++------------
hw/ppc/sam460ex.c | 8 ++------
hw/ppc/spapr.c | 17 ++++------------
hw/ppc/virtex_ml507.c | 11 +++--------
hw/riscv/boot.c | 7 ++++---
hw/rx/rx-gdbsim.c | 2 +-
hw/s390x/ipl.c | 8 +++++---
hw/sh4/r2d.c | 8 +++++---
hw/smbios/smbios.c | 2 +-
hw/sparc/leon3.c | 4 ++--
hw/sparc/sun4m.c | 8 +++++---
hw/sparc64/sun4u.c | 7 ++++---
hw/xtensa/xtfpga.c | 3 ++-
include/hw/loader.h | 8 +++++---
system/device_tree.c | 2 +-
51 files changed, 170 insertions(+), 215 deletions(-)
