Hi On Tue, Oct 28, 2025 at 12:04 PM Philippe Mathieu-Daudé <[email protected]> wrote: > > - Use proper SysBus accessors > > Since v1: > - Reduce series > > Philippe Mathieu-Daudé (7): > hw/sysbus: Use memory_region_name() > hw/i386/microvm: Use proper SysBus accessors > hw/i386/ioapic: Use proper SysBus accessors > hw/timer/hpet: Use proper SysBus accessors > hw/acpi/cxl: Use proper SysBus accessors > hw/ppc/e500: Use proper SysBus accessors > hw/pci-bridge/pci_expander_bridge: Use proper SysBus accessors >
There are a bunch of compilation issues that I will let you address for v3. It looks like it should be possible to remove the "addr" field from SysBusDevice.mmio. On the surface it looks redundante with MemoryRegion.addr. I might be missing something. > hw/acpi/cxl.c | 2 +- > hw/core/sysbus.c | 2 +- > hw/i386/kvm/ioapic.c | 3 ++- > hw/i386/microvm-dt.c | 6 ++++-- > hw/pci-bridge/pci_expander_bridge.c | 6 +++--- > hw/ppc/e500.c | 2 +- > hw/timer/hpet.c | 3 ++- > 7 files changed, 14 insertions(+), 10 deletions(-) > > -- > 2.51.0 > > -- Marc-André Lureau
