On Tue, 28 Oct 2025 at 08:50, Marc-André Lureau <[email protected]> wrote: > > Hi > > On Tue, Oct 28, 2025 at 12:04 PM Philippe Mathieu-Daudé > <[email protected]> wrote: > > > > - Use proper SysBus accessors > > > > Since v1: > > - Reduce series > > > > Philippe Mathieu-Daudé (7): > > hw/sysbus: Use memory_region_name() > > hw/i386/microvm: Use proper SysBus accessors > > hw/i386/ioapic: Use proper SysBus accessors > > hw/timer/hpet: Use proper SysBus accessors > > hw/acpi/cxl: Use proper SysBus accessors > > hw/ppc/e500: Use proper SysBus accessors > > hw/pci-bridge/pci_expander_bridge: Use proper SysBus accessors > > > > There are a bunch of compilation issues that I will let you address for v3. > > It looks like it should be possible to remove the "addr" field from > SysBusDevice.mmio. On the surface it looks redundante with > MemoryRegion.addr. I might be missing something.
Yes, I think they'll always be the same value. But MemoryRegion::addr is private data of MemoryRegion and there's no 'get' function provided; SysBus shouldn't be reaching inside an MR struct to look at its internals. (There is a memory_region_set_address(), so we could I guess provide a memory_region_get_address() ?) -- PMM
