On Wed, 29 Oct 2025, BALATON Zoltan wrote:
On Wed, 29 Oct 2025, Akihiko Odaki wrote:
On 2025/10/29 6:28, BALATON Zoltan wrote:
On Wed, 29 Oct 2025, Akihiko Odaki wrote:
On 2025/10/28 21:59, BALATON Zoltan wrote:
On Tue, 28 Oct 2025, Philippe Mathieu-Daudé wrote:
On 27/10/25 20:47, BALATON Zoltan wrote:
On Mon, 27 Oct 2025, Philippe Mathieu-Daudé wrote:
On 25/10/25 01:31, BALATON Zoltan wrote:
These memory windows are a result of the address decoding in the
Articia S north bridge so better model it there and not in board
code.
Suggested-by: Philippe Mathieu-Daudé <[email protected]>
Signed-off-by: BALATON Zoltan <[email protected]>
---
hw/pci-host/articia.c | 15 ++++++++++++++-
hw/ppc/amigaone.c | 28 +++++-----------------------
hw/ppc/pegasos2.c | 13 -------------
3 files changed, 19 insertions(+), 37 deletions(-)
[...]
It looks like we won't be able to come to an agreement before the freeze and
I don't have time now to change this patch but don't want to miss the release
with this series that finishes pegasos renaming because of this. So for this
patch I'd say since this is already how it is now and it does not make it
worse and this object is not user creatable anyway so cannot leak please take
it as it is and we'll do a clean up later after we finish discussion.
As for all of these files I'm the maintainer let me make an executive
decision here to keep this patch without Philippe's reviewed-by for now to
be able to move on with this series before the freeze. Fixing the
theoretical leak can be done on top and since that's a fix it can be done
during soft freeze that would give us more time. So Harsh please go ahead
and merge this series too if there are no other concerns. I'll then
address this later together with other similar issues elsewhere.
Regards,
BALATON Zoltan
