On 10/30/25 10:49, Xiaoyao Li wrote:
On 10/30/2025 3:36 PM, Michael Tokarev wrote:
On 10/28/25 20:34, Paolo Bonzini wrote:
From: Xiaoyao Li <[email protected]>
The SMM cpu address space is initialized in a machine_init_done
notifier. It only runs once when QEMU starts up, which leads to the
issue that for any hotplugged CPU after the machine is ready, SMM
cpu address space doesn't get initialized.
Fix the issue by initializing the SMM cpu address space in
x86_cpu_plug()
when the cpu is hotplugged.
Fixes: 591f817d819f ("target/i386: Define enum X86ASIdx for x86's
address spaces")
How this commit can be fixing 591f817d819f, while technically
591f817d819f is a no-op, - it changed 0s and 1s in a few places
to symbolic names with the same 0s and 1s.
It seems the "Fixes" commit should be something else.
The way it is now, it's confusing.
It should be
0516f4b70264 ("i386/cpu: Enable SMM cpu address space under KVM")
Sorry for my carelessness. Is there a way to remedy as the patch has
been merged into the master?
I hope it's possible still.
Paolo, please also add Cc: qemu-stable@ in there, -- because the change
which is being fixed here (Enable SMM cpu address space) has been picked
up to the stable series too. It's best to keep all the pieces :)
Thank you Xiaoyao, Paolo!
/mjt
