On Fri, Oct 31, 2025 at 01:18:54PM +0300, Michael Tokarev wrote: > On 10/29/25 15:06, Kevin Wolf wrote: > > From: Daniel P. Berrangé <[email protected]> > > > > Launch QEMU with > > > > $ qemu-img create \ > > --object secret,id=sec0,data=123456 \ > > -f luks -o key-secret=sec0 demo.luks 1g > > > > $ qemu-system-x86_64 \ > > --object secret,id=sec0,data=123456 \ > > -blockdev > > driver=luks,key-secret=sec0,file.filename=demo.luks,file.driver=file,node-name=luks > > > > Then in QMP shell attempt > > > > x-blockdev-amend job-id=fish node-name=luks > > options={'state':'active','new-secret':'sec0','driver':'luks'} > > > > It will result in an assertion > > Is this a qemu-stable material (for 10.0 & 10.1), > or is it not because it's an x-command? :) > > I picked it up for now, please let me know if I shouldn't.
Yes that's good. Also please pick up the previous patch 02 which fixes another luks bug. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
