> -----Original Message-----
> From: Nicolin Chen <[email protected]>
> Sent: 01 November 2025 00:35
> To: Shameer Kolothum <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; Jason Gunthorpe
> <[email protected]>; [email protected]; [email protected]; Nathan
> Chen <[email protected]>; Matt Ochs <[email protected]>;
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> Krishnakant Jaju <[email protected]>
> Subject: Re: [PATCH v5 17/32] hw/arm/smmuv3-accel: Add support to issue
> invalidation cmd to host
>
> On Fri, Oct 31, 2025 at 10:49:50AM +0000, Shameer Kolothum wrote:
> > Provide a helper and use that to issue the invalidation cmd to host SMMUv3.
> > We only issue one cmd at a time for now.
> >
> > Support for batching of commands will be added later after analysing the
> > impact.
> >
> > Reviewed-by: Jonathan Cameron <[email protected]>
> > Tested-by: Zhangfei Gao <[email protected]>
> > Signed-off-by: Shameer Kolothum <[email protected]>
>
> I think I have given my tag in v4.. anyway..
Sorry I missed that.
>
> Reviewed-by: Nicolin Chen <[email protected]>
Thanks.
> > case SMMU_CMD_TLBI_NH_VAA:
> > case SMMU_CMD_TLBI_NH_VA:
> > + {
> > + Error *local_err = NULL;
> > +
> > if (!STAGE1_SUPPORTED(s)) {
> > cmd_error = SMMU_CERROR_ILL;
> > break;
> > }
> > smmuv3_range_inval(bs, &cmd, SMMU_STAGE_1);
> > + if (!smmuv3_accel_issue_inv_cmd(s, &cmd, NULL, &local_err)) {
> > + error_report_err(local_err);
> > + cmd_error = SMMU_CERROR_ILL;
> > + break;
> > + }
> > break;
> > + }
>
> The local_err isn't used anywhere but by the error_report_err()
> alone. So, it could be moved into smmuv3_accel_issue_inv_cmd().
Though that is true, it is following the same pattern as
smmuv3_accel_install_nested_ste()/_range() functions. The general
idea is, we will pass the errp to accel functions and report or propagate
from here.
Thanks,
Shameer
