> -----Original Message-----
> From: Nicolin Chen <[email protected]>
> Sent: 03 November 2025 17:44
> To: Shameer Kolothum <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; Jason Gunthorpe
> <[email protected]>; [email protected]; [email protected]; Nathan
> Chen <[email protected]>; Matt Ochs <[email protected]>;
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> Krishnakant Jaju <[email protected]>
> Subject: Re: [PATCH v5 17/32] hw/arm/smmuv3-accel: Add support to issue
> invalidation cmd to host
>
> >
> > Though that is true, it is following the same pattern as
> > smmuv3_accel_install_nested_ste()/_range() functions.
>
> We could drop the one in smmuv3_accel_install_nested_ste() too.
>
> > The general
> > idea is, we will pass the errp to accel functions and report or
> > propagate from here.
>
> But there is no "errp" in smmuv3_cmdq_consume() to propagate the these
> local_errs further? It ends at the error_report_err().
>
> If we only get local_err and print them, why not just print them inside the
> _accel functions?
Right, we don't propagate error now. But in future it might come
handy. I would personally keep the error propagation facility if possible.
Also, this was added as per Eric's comment on RFC v3.
https://lore.kernel.org/qemu-devel/[email protected]/
Thanks,
Shameer
