Thanks @Peter Maydell for the guidance. I am splitting this patch into a series of patches. I will soon send it across. For some reasons, git send-email doesn't seem to work on my official machine due to some smtp restrictions from IT. I am figuring out a workaround with the IT dept. so that I can use 'git send-email' itself. Otherwise, I might have to resort to another alternative.
Regards -----Original Message----- From: Peter Maydell <[email protected]> Sent: 09 November 2025 00:35 To: Gaurav Sharma <[email protected]> Cc: [email protected]; [email protected] Subject: [EXT] Re: [PATCH] Add support for the NXP i.MX8MM EVK (Evaluation Kit) board Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button On Sat, 8 Nov 2025 at 12:27, Gaurav Sharma <[email protected]> wrote: > > From: Gaurav Sharma [email protected] > > Date: Sat, 8 Nov 2025 17:12:56 +0530 > > Subject: [PATCH] Add support for the NXP i.MX8MM EVK (Evaluation Kit) > board > > including: - i.MX8MM SoC implementation with CPU, memory, and > peripherals - > > Board-specific configuration and device tree - Clock Control Module > (CCM) for > > i.MX8MM - Analog mixed-signal controller - Updated GPT timer support > for > > i.MX8MM - Documentation for the new board > > > > Signed-off-by: Gaurav Sharma [email protected]" > > --- > > MAINTAINERS | 12 + > > docs/system/arm/imx8mm-evk.rst | 69 ++++ > > hw/arm/Kconfig | 24 ++ > > hw/arm/fsl-imx8mm.c | 675 ++++++++++++++++++++++++++++++++ > > hw/arm/imx8mm-evk.c | 103 +++++ > > hw/arm/meson.build | 2 + > > hw/misc/Kconfig | 6 + > > hw/misc/imx8mm_analog.c | 160 ++++++++ > > hw/misc/imx8mm_ccm.c | 175 +++++++++ > > hw/misc/meson.build | 3 + > > hw/timer/imx_gpt.c | 28 ++ > > include/hw/arm/fsl-imx8mm.h | 242 ++++++++++++ > > include/hw/misc/imx8mm_analog.h | 81 ++++ > > include/hw/misc/imx8mm_ccm.h | 30 ++ > > include/hw/timer/imx_gpt.h | 3 + > > 15 files changed, 1613 insertions(+) Please can you split this up into a multi-patch patch series where each patch is a self-contained reasonably sized change? You can look through the git history for examples, but typically adding each individual new device model should be in its own patch, for example. Also, it looks like you've sent this as something other than a plain text email. You'll probably find git send-email will produce better results than sending it from your normal mail client. You can find our guidance on how to send patches here: https://www.qemu.org/docs/master/devel/submitting-a-patch.html (which includes some tips about setting up tooling to send patch emails). Thanks for including documentation with the new board model. Another thing that we like these days for new boards is a simple functional test under tests/functional/ which exercises the board by doing a simple "run a guest image and check it boots" test. You can find various examples under there to use as a template. thanks -- PMM
