Clément Chigot <[email protected]> writes:
> This allows more flexibility to vvfat backend. The values of "Number of
> Heads" and "Sectors per track" are based on SD specifications Part 2.
>
> Due to the FAT architecture, not all sizes are reachable. Therefore, it
> could be round up to the closest available size.
>
> FAT32 has not been adjusted and thus still default to 504 Mib.
>
> For floppy, only 1440 Kib and 2880 Kib are supported.
>
> Signed-off-by: Clément Chigot <[email protected]>
[...]
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 8a479ba090..0bcb360320 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -3478,11 +3478,17 @@
> # (default: true)
> # (since 10.2)
> #
> +# @fat-size: size of the device in bytes. Due to FAT underlying
> +# architecture, this size can be rounded up to the closest valid
> +# size.
> +# (since 10.2)
> +#
Can you explain again why you moved from @size to @fat-size?
I assume you dropped the horrible special floppy sizes because ordinary
sizes suffice. Correct?
> # Since: 2.9
> ##
> { 'struct': 'BlockdevOptionsVVFAT',
> 'data': { 'dir': 'str', '*fat-type': 'int', '*floppy': 'bool',
> - '*label': 'str', '*rw': 'bool', '*partitioned': 'bool' } }
> + '*label': 'str', '*rw': 'bool', '*partitioned': 'bool',
> + 'fat-size': 'int' } }
>
> ##
> # @BlockdevOptionsGenericFormat:
