On Tue, 11 Nov 2025 at 10:54, Alex Bennée <[email protected]> wrote: > > The datasheet doesn't explicitly say that TXFR_LEN has to be word > aligned but the fact there is a DMA_D_WIDTH flag to select between 32 > bit and 128 bit strongly implies that is how it works. The downstream > rpi kernel also goes to efforts to not write sub-4 byte lengths so > lets: > > - fail when mis-programmed and report GUEST_ERROR > - catch setting D_WIDTH for 128 bit and report UNIMP > - add comments that the DEBUG register isn't a straight write > > This includes the test case from the reported bug which is of unknown > provenience but isn't particularly novel.
The emoji in the comment seems like a bit of a flag that it might be AI-generated :-) I would at least clean up the comments to be more in line with our usual style and degree of detail. thanks -- PMM
