On 4/11/25 10:54, Vladimir Sementsov-Ogievskiy wrote:
On 03.11.25 16:19, Philippe Mathieu-Daudé wrote:
On 3/11/25 10:20, Richard Henderson wrote:
On 11/2/25 19:14, Philippe Mathieu-Daudé wrote:
Vladimir Sementsov-Ogievskiy (2):
util/hexdump: fix QEMU_HEXDUMP_LINE_WIDTH logic
tests/unit: add unit test for qemu_hexdump()
This doesn't build:
https://gitlab.com/qemu-project/qemu/-/jobs/11947161300
https://gitlab.com/qemu-project/qemu/-/jobs/11947161195
and 10 other variations.
Nice. Apologies for missing that.
Oops, my fault.
Vladimir, please repost (only) the test:
https://lore.kernel.org/qemu-devel/20251031211518.38503-9-
[email protected]/
Hmmm. But how to correctly fix it?
As I understand, the problem is that
util_ss.add(files('hexdump.c'))
comes inside
if have_block
block, so it miss targets without block subsystem?
Likely: we can build QEMU user emulation without system / block.
Would it be more correct, to just move `util_ss.add(files('hexdump.c'))`
out of the block, so it compile always, like many other "utils"?
Actually, qemu_hexdump() itself is unrelated to block..
I concur, this should be the correct fix.
Thanks,
Phil.
