This series implements HOST_DATA as a blit source enabling text rendering in
xterm under X.org with 2D acceleration.
The series builds up functionality incrementally:
* Patches 1-5: Bug fixes and register implementations
* Patches 6-7: Scissor clipping
* Patches 8-9: Destination setup refactor
* Patches 10-11: HOST_DATA register writes, color expansion, and
accumulator flush
Tested with xterm on X.org using the r128 driver built with
--disable-dri (MMIO mode).
Hardware tests can be found at: https://codeberg.org/cjab/ati-tests.
Changes from v2:
- Verified with hardware that clipping default bit latches
- Verified with hardware that pitch/offset default bits latch
(supersedes BALATON's "ati-vga: Separate default control bit for
source")
- A new approach to HOST_DATA using a 128-bit accumulator instead of a
large buffer
- Fixed a longstanding bug in (DST/SRC)_PITCH reads that zeroed pitch value.
- Removed mask from the DP_GUI_MASTER_CNTL write, all fields are
important
- Created helpers for code shared between ati_2d_blt and
ati_host_data_flush
Changes from v1:
- Split monolithic patch into 7 logical patches as requested
- Integrate HOST_DATA blit into existing ati_2d_blt()
- Add fallback implementation for non-pixman builds
- Remove unnecessary initialization in realize (kept in reset only)
- Fixed DP_GUI_MASTER_CNTL mask to preserve GMC_SRC_SOURCE field
- Implement scissor clipping
Chad Jablonski (11):
ati-vga: Fix DST_PITCH and SRC_PITCH reads
ati-vga: Add scissor clipping register support
ati-vga: Implement foreground and background color register writes
ati-vga: Latch src and dst pitch and offset on master_cntl default
ati-vga: Fix DP_GUI_MASTER_CNTL register mask
ati-vga: Create dst and sc rectangle helpers
ati-vga: Implement scissor rectangle clipping for 2D operations
ati-vga: Create 2d_blt destination setup helper
ati-vga: Refactor ati_2d_blt to use dst setup helper
ati-vga: Implement HOST_DATA register writes
ati-vga: Implement HOST_DATA flush to VRAM
hw/display/ati.c | 124 +++++++++++++-
hw/display/ati_2d.c | 370 +++++++++++++++++++++++++++++++-----------
hw/display/ati_dbg.c | 9 +
hw/display/ati_int.h | 21 ++-
hw/display/ati_regs.h | 44 ++++-
5 files changed, 467 insertions(+), 101 deletions(-)
--
2.51.0
