Re: [PATCH v6 28/33] hw/arm/smmuv3-accel: Add support for ATS

[Nicolin Chen]

On Thu, Nov 20, 2025 at 01:22:08PM +0000, Shameer Kolothum wrote:
> diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c
> index 296afbe503..ad476146f6 100644
> --- a/hw/arm/smmuv3.c
> +++ b/hw/arm/smmuv3.c
> @@ -1498,13 +1498,24 @@ static int smmuv3_cmdq_consume(SMMUv3State *s, Error 
> **errp)
>               */
>              smmuv3_range_inval(bs, &cmd, SMMU_STAGE_2);
>              break;
> +        case SMMU_CMD_ATC_INV:
> +            SMMUDevice *sdev = smmu_find_sdev(bs, CMD_SID(&cmd));
> +
> +            if (!sdev) {
> +                break;
> +            }

Should we do:
    if (!sdev || !s->ats) {
        trace_smmuv3_unhandled_cmd(type);
        break;
    }
?

Otherwise,

Reviewed-by: Nicolin Chen <nicol...@nvidia.com>