On 24/11/25 14:56, BALATON Zoltan wrote:
On Mon, 24 Nov 2025, Philippe Mathieu-Daudé wrote:
Commit 7ee6c1e182c ("pci: Permit incremental conversion of
device models to realize") renamed:
PCIDeviceClass::init() -> PCIDeviceClass::realize()
Finish the conversion by renaming the counter part
PCIDeviceClass::exit() PCIDeviceClass::unrealize()
This clarifies the handler is called during the DeviceUnrealize
path, not during Object destruction in instance_finalize().
Manual change adapting style when needed.
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
---
include/hw/pci/pci.h | 1 -
include/hw/pci/pci_device.h | 3 ++-
hw/audio/ac97.c | 8 ++++----
hw/audio/es1370.c | 8 ++++----
hw/audio/intel-hda.c | 8 ++++----
hw/audio/via-ac97.c | 4 ++--
hw/char/diva-gsp.c | 6 +++---
hw/char/serial-pci-multi.c | 8 ++++----
hw/char/serial-pci.c | 4 ++--
hw/cxl/switch-mailbox-cci.c | 4 ++--
hw/display/ati.c | 8 ++++----
hw/display/bochs-display.c | 4 ++--
hw/display/vga-pci.c | 4 ++--
hw/ide/cmd646.c | 4 ++--
hw/ide/ich.c | 4 ++--
hw/ide/piix.c | 6 +++---
hw/ide/via.c | 4 ++--
hw/mem/cxl_type3.c | 4 ++--
hw/misc/edu.c | 4 ++--
hw/misc/ivshmem-pci.c | 4 ++--
hw/misc/pci-testdev.c | 5 ++---
hw/net/can/can_kvaser_pci.c | 4 ++--
hw/net/can/can_mioe3680_pci.c | 4 ++--
hw/net/can/can_pcm3680_pci.c | 4 ++--
hw/net/can/ctucan_pci.c | 4 ++--
hw/net/e1000.c | 5 ++---
hw/net/e1000e.c | 4 ++--
hw/net/eepro100.c | 8 ++++----
hw/net/igb.c | 4 ++--
hw/net/igbvf.c | 4 ++--
hw/net/ne2000-pci.c | 4 ++--
hw/net/pcnet-pci.c | 4 ++--
hw/net/rocker/rocker.c | 4 ++--
hw/net/rtl8139.c | 4 ++--
hw/net/sungem.c | 4 ++--
hw/net/tulip.c | 4 ++--
hw/net/vmxnet3.c | 4 ++--
hw/nvme/ctrl.c | 4 ++--
hw/pci-bridge/cxl_downstream.c | 4 ++--
hw/pci-bridge/cxl_root_port.c | 2 +-
hw/pci-bridge/cxl_upstream.c | 4 ++--
hw/pci-bridge/gen_pcie_root_port.c | 2 +-
hw/pci-bridge/pci_bridge_dev.c | 4 ++--
hw/pci-bridge/pci_expander_bridge.c | 8 ++++----
hw/pci-bridge/pcie_pci_bridge.c | 4 ++--
hw/pci-bridge/pcie_root_port.c | 4 ++--
hw/pci-bridge/simba.c | 2 +-
hw/pci-bridge/xio3130_downstream.c | 4 ++--
hw/pci-bridge/xio3130_upstream.c | 4 ++--
hw/pci-host/designware.c | 2 +-
hw/pci-host/xilinx-pcie.c | 2 +-
hw/pci/pci.c | 4 ++--
hw/remote/proxy.c | 4 ++--
hw/riscv/riscv-iommu-pci.c | 4 ++--
hw/scsi/esp-pci.c | 4 ++--
hw/scsi/lsi53c895a.c | 4 ++--
hw/scsi/megasas.c | 4 ++--
hw/scsi/mptsas.c | 4 ++--
hw/scsi/vmw_pvscsi.c | 10 ++++------
hw/sd/sdhci-pci.c | 4 ++--
hw/ufs/ufs.c | 4 ++--
hw/usb/hcd-ehci-pci.c | 4 ++--
hw/usb/hcd-ohci-pci.c | 8 ++++----
hw/usb/hcd-uhci.c | 4 ++--
hw/usb/hcd-xhci-pci.c | 4 ++--
hw/vfio/pci.c | 4 ++--
hw/virtio/virtio-pci.c | 4 ++--
hw/watchdog/wdt_i6300esb.c | 4 ++--
hw/xen/xen_pt.c | 4 ++--
69 files changed, 151 insertions(+), 155 deletions(-)
[...]
diff --git a/hw/display/ati.c b/hw/display/ati.c
index f7c0006a879..6b9f06b6b36 100644
--- a/hw/display/ati.c
+++ b/hw/display/ati.c
@@ -948,7 +948,7 @@ static const MemoryRegionOps ati_mm_ops = {
.endianness = DEVICE_LITTLE_ENDIAN,
};
-static void ati_vga_realize(PCIDevice *dev, Error **errp)
+static void ati_vga_pci_realize(PCIDevice *dev, Error **errp)
Why rename this?
{
ATIVGAState *s = ATI_VGA(dev);
VGACommonState *vga = &s->vga;
@@ -1032,7 +1032,7 @@ static void ati_vga_reset(DeviceState *dev)
s->mode = VGA_MODE;
}
-static void ati_vga_exit(PCIDevice *dev)
+static void ati_vga_pci_unrealize(PCIDevice *dev)
Can you just call it ati_vga_unrealize like in other devices?
Sure, will do in v2.
