On 11/25/25 15:09, Alex Bennée wrote: > Dmitry Osipenko <[email protected]> writes: > >> Make virtio_gpu_virgl_unmap_resource_blob() return -1 for more consistency >> of error propagation style in the code, adhering to QEMU's devel/style >> recommendations and preparing code for further code changes utilizing this >> function. > I'm not so sure of that. If the function is a pass/fail then we tend to > prefer using bools in newer code. If you need richer internal error > reporting then start using your errno defines. If this is user visible > (i.e. during configuration) then we can make more of Error* and friends.
The current code is a mix of all variants. Will be good to stick with one. Akihiko, what are your thoughts on the best option for the errors handling? Would you also prefer bools? -- Best regards, Dmitry
