> -----Original Message----- > From: Peter Maydell <[email protected]> > Sent: 02 December 2025 15:17 > To: Gaurav Sharma <[email protected]> > Cc: [email protected]; [email protected] > Subject: Re: [EXT] Re: [PATCHv3 02/13] hw/arm/fsl-imx8mm: Implemented > CCM(Clock Control Module) and Analog IP > > Caution: This is an external email. Please take care when clicking links or > opening attachments. When in doubt, report the message using the 'Report > this email' button > > > On Tue, 2 Dec 2025 at 09:32, Gaurav Sharma <[email protected]> > wrote: > > Apologies. I should have executed my earlier plan to maximise code > > re-use. Memory map of Analog and the reset values of the registers are > > almost identical. we should re-use the 8mp code. I will create another patch > revision that 1. will have code-reuse of imx8mp CCM and Analog 2. will add a > uint32 property 'arm_pll_fdiv_ctl0_reset' in imx8mp analog state struct. > imx8mp analog class init will be setting it to its default reset-value. in > fsl- > imx8mm we will be overriding this default value with 8mm's reset value. > > 3. Update the 8mm documentation mentioning the ccm and analog re-use > > You don't need to mention this in the user-facing documentation; it's just an > implementation detail. Otherwise this sounds OK.
Okay. > > One question regarding the patch splitting you proposed earlier- Now > > that we are re-using ccm and analog of 8mp, will it be like 3 patches > > ? :- > > 1 patch that adds CCM device to 8mm in Kconfig > > 1 patch that adds Analog device to 8mm in Kconfig > > 1 patch that adds the property 'arm_pll_fdiv_ctl0_reset' in 8mp analog > > source > > You can structure it like this: > patch 1: add the new property to the analog device patch 2: add the analog > device to the 8mm board (setting > the property) > patch 3: add the CCM device to the 8mm board > Understood
