On Fri, Nov 14, 2025 at 5:00 PM Taylor Simpson <[email protected]> wrote:
> Note there are two functions impacted > gen_log_vreg_write -> gen_vreg_write > gen_log_vreg_write_pair -> gen_vreg_write_pair > These functions don't "log" anything, they just generate the write > > Signed-off-by: Taylor Simpson <[email protected]> > --- > target/hexagon/genptr.c | 8 ++++---- > target/hexagon/hex_common.py | 8 ++++---- > 2 files changed, 8 insertions(+), 8 deletions(-) > > Reviewed-by: Brian Cain <[email protected]> > diff --git a/target/hexagon/genptr.c b/target/hexagon/genptr.c > index bfbbd61c33..616db17907 100644 > --- a/target/hexagon/genptr.c > +++ b/target/hexagon/genptr.c > @@ -1174,7 +1174,7 @@ static intptr_t vreg_src_off(DisasContext *ctx, int > num) > return offset; > } > > -static void gen_log_vreg_write(DisasContext *ctx, intptr_t srcoff, int > num, > +static void gen_vreg_write(DisasContext *ctx, intptr_t srcoff, int num, > VRegWriteType type) > { > intptr_t dstoff; > @@ -1190,12 +1190,12 @@ static void gen_log_vreg_write(DisasContext *ctx, > intptr_t srcoff, int num, > } > } > > -static void gen_log_vreg_write_pair(DisasContext *ctx, intptr_t srcoff, > int num, > +static void gen_vreg_write_pair(DisasContext *ctx, intptr_t srcoff, int > num, > VRegWriteType type) > { > - gen_log_vreg_write(ctx, srcoff, num ^ 0, type); > + gen_vreg_write(ctx, srcoff, num ^ 0, type); > srcoff += sizeof(MMVector); > - gen_log_vreg_write(ctx, srcoff, num ^ 1, type); > + gen_vreg_write(ctx, srcoff, num ^ 1, type); > } > > static intptr_t get_result_qreg(DisasContext *ctx, int qnum) > diff --git a/target/hexagon/hex_common.py b/target/hexagon/hex_common.py > index 1277fec9a2..6b683487bc 100755 > --- a/target/hexagon/hex_common.py > +++ b/target/hexagon/hex_common.py > @@ -823,8 +823,8 @@ def decl_tcg(self, f, tag, regno): > """)) > def log_write(self, f, tag): > f.write(code_fmt(f"""\ > - gen_log_vreg_write(ctx, {self.hvx_off()}, {self.reg_num}, > - {hvx_newv(tag)}); > + gen_vreg_write(ctx, {self.hvx_off()}, {self.reg_num}, > + {hvx_newv(tag)}); > """)) > def helper_hvx_desc(self, f): > f.write(code_fmt(f"""\ > @@ -915,8 +915,8 @@ def decl_tcg(self, f, tag, regno): > """)) > def log_write(self, f, tag): > f.write(code_fmt(f"""\ > - gen_log_vreg_write_pair(ctx, {self.hvx_off()}, {self.reg_num}, > - {hvx_newv(tag)}); > + gen_vreg_write_pair(ctx, {self.hvx_off()}, {self.reg_num}, > + {hvx_newv(tag)}); > """)) > def helper_hvx_desc(self, f): > f.write(code_fmt(f"""\ > -- > 2.43.0 > >
