On Fri, Nov 14, 2025 at 5:00 PM Taylor Simpson <[email protected]> wrote:
> These functions don't "log" anything, they just generate the write > > Signed-off-by: Taylor Simpson <[email protected]> > --- > target/hexagon/gen_tcg_funcs.py | 2 +- > target/hexagon/hex_common.py | 30 +++++++++++++++--------------- > 2 files changed, 16 insertions(+), 16 deletions(-) > > Reviewed-by: Brian Cain <[email protected]> > diff --git a/target/hexagon/gen_tcg_funcs.py > b/target/hexagon/gen_tcg_funcs.py > index bd241afde1..3e531bd540 100755 > --- a/target/hexagon/gen_tcg_funcs.py > +++ b/target/hexagon/gen_tcg_funcs.py > @@ -94,7 +94,7 @@ def gen_tcg_func(f, tag, regs, imms): > for regtype, regid in regs: > reg = hex_common.get_register(tag, regtype, regid) > if reg.is_written(): > - reg.log_write(f, tag) > + reg.gen_write(f, tag) > > f.write("}\n\n") > > diff --git a/target/hexagon/hex_common.py b/target/hexagon/hex_common.py > index 6b683487bc..c0e9f26aeb 100755 > --- a/target/hexagon/hex_common.py > +++ b/target/hexagon/hex_common.py > @@ -451,7 +451,7 @@ def decl_tcg(self, f, tag, regno): > f.write(code_fmt(f"""\ > TCGv {self.reg_tcg()} = get_result_gpr(ctx, {self.reg_num}); > """)) > - def log_write(self, f, tag): > + def gen_write(self, f, tag): > ## No write needed > return > def analyze_write(self, f, tag, regno): > @@ -494,7 +494,7 @@ def decl_tcg(self, f, tag, regno): > f.write(code_fmt(f"""\ > tcg_gen_mov_tl({self.reg_tcg()}, hex_gpr[{self.reg_num}]); > """)) > - def log_write(self, f, tag): > + def gen_write(self, f, tag): > ## No write needed > return > def analyze_read(self, f, regno): > @@ -517,7 +517,7 @@ def decl_tcg(self, f, tag, regno): > f.write(code_fmt(f"""\ > TCGv {self.reg_tcg()} = get_result_gpr(ctx, {self.reg_num}); > """)) > - def log_write(self, f, tag): > + def gen_write(self, f, tag): > f.write(code_fmt(f"""\ > gen_write_ctrl_reg(ctx, {self.reg_num}, {self.reg_tcg()}); > """)) > @@ -569,7 +569,7 @@ def decl_tcg(self, f, tag, regno): > f.write(code_fmt(f"""\ > TCGv {self.reg_tcg()} = tcg_temp_new(); > """)) > - def log_write(self, f, tag): > + def gen_write(self, f, tag): > f.write(code_fmt(f"""\ > gen_pred_write(ctx, {self.reg_num}, {self.reg_tcg()}); > """)) > @@ -606,7 +606,7 @@ def decl_tcg(self, f, tag, regno): > TCGv {self.reg_tcg()} = tcg_temp_new(); > tcg_gen_mov_tl({self.reg_tcg()}, hex_pred[{self.reg_num}]); > """)) > - def log_write(self, f, tag): > + def gen_write(self, f, tag): > f.write(code_fmt(f"""\ > gen_pred_write(ctx, {self.reg_num}, {self.reg_tcg()}); > """)) > @@ -626,7 +626,7 @@ def decl_tcg(self, f, tag, regno): > TCGv_i64 {self.reg_tcg()} = > get_result_gpr_pair(ctx, {self.reg_num}); > """)) > - def log_write(self, f, tag): > + def gen_write(self, f, tag): > f.write(code_fmt(f"""\ > gen_write_reg_pair(ctx, {self.reg_num}, {self.reg_tcg()}); > """)) > @@ -660,7 +660,7 @@ def decl_tcg(self, f, tag, regno): > hex_gpr[{self.reg_num}], > hex_gpr[{self.reg_num} + 1]); > """)) > - def log_write(self, f, tag): > + def gen_write(self, f, tag): > f.write(code_fmt(f"""\ > gen_write_reg_pair(ctx, {self.reg_num}, {self.reg_tcg()}); > """)) > @@ -685,7 +685,7 @@ def decl_tcg(self, f, tag, regno): > TCGv_i64 {self.reg_tcg()} = > get_result_gpr_pair(ctx, {self.reg_num}); > """)) > - def log_write(self, f, tag): > + def gen_write(self, f, tag): > f.write(code_fmt(f"""\ > gen_write_ctrl_reg_pair(ctx, {self.reg_num}, > {self.reg_tcg()}); > """)) > @@ -723,7 +723,7 @@ def decl_tcg(self, f, tag, regno): > TCGv_ptr {self.reg_tcg()} = tcg_temp_new_ptr(); > tcg_gen_addi_ptr({self.reg_tcg()}, tcg_env, > {self.hvx_off()}); > """)) > - def log_write(self, f, tag): > + def gen_write(self, f, tag): > pass > def helper_hvx_desc(self, f): > f.write(code_fmt(f"""\ > @@ -789,7 +789,7 @@ def decl_tcg(self, f, tag, regno): > TCGv_ptr {self.reg_tcg()} = tcg_temp_new_ptr(); > tcg_gen_addi_ptr({self.reg_tcg()}, tcg_env, > {self.hvx_off()}); > """)) > - def log_write(self, f, tag): > + def gen_write(self, f, tag): > pass > def helper_hvx_desc(self, f): > f.write(code_fmt(f"""\ > @@ -821,7 +821,7 @@ def decl_tcg(self, f, tag, regno): > vreg_src_off(ctx, {self.reg_num}), > sizeof(MMVector), sizeof(MMVector)); > """)) > - def log_write(self, f, tag): > + def gen_write(self, f, tag): > f.write(code_fmt(f"""\ > gen_vreg_write(ctx, {self.hvx_off()}, {self.reg_num}, > {hvx_newv(tag)}); > @@ -854,7 +854,7 @@ def decl_tcg(self, f, tag, regno): > TCGv_ptr {self.reg_tcg()} = tcg_temp_new_ptr(); > tcg_gen_addi_ptr({self.reg_tcg()}, tcg_env, > {self.hvx_off()}); > """)) > - def log_write(self, f, tag): > + def gen_write(self, f, tag): > pass > def helper_hvx_desc(self, f): > f.write(code_fmt(f"""\ > @@ -913,7 +913,7 @@ def decl_tcg(self, f, tag, regno): > TCGv_ptr {self.reg_tcg()} = tcg_temp_new_ptr(); > tcg_gen_addi_ptr({self.reg_tcg()}, tcg_env, > {self.hvx_off()}); > """)) > - def log_write(self, f, tag): > + def gen_write(self, f, tag): > f.write(code_fmt(f"""\ > gen_vreg_write_pair(ctx, {self.hvx_off()}, {self.reg_num}, > {hvx_newv(tag)}); > @@ -946,7 +946,7 @@ def decl_tcg(self, f, tag, regno): > TCGv_ptr {self.reg_tcg()} = tcg_temp_new_ptr(); > tcg_gen_addi_ptr({self.reg_tcg()}, tcg_env, > {self.hvx_off()}); > """)) > - def log_write(self, f, tag): > + def gen_write(self, f, tag): > pass > def helper_hvx_desc(self, f): > f.write(code_fmt(f"""\ > @@ -993,7 +993,7 @@ def decl_tcg(self, f, tag, regno): > TCGv_ptr {self.reg_tcg()} = tcg_temp_new_ptr(); > tcg_gen_addi_ptr({self.reg_tcg()}, tcg_env, > {self.hvx_off()}); > """)) > - def log_write(self, f, tag): > + def gen_write(self, f, tag): > pass > def helper_hvx_desc(self, f): > f.write(code_fmt(f"""\ > -- > 2.43.0 > >
