On 12 July 2012 14:22, Igor Mammedov <imamm...@redhat.com> wrote: > This patch: > - moves decision to designate BSP from board into cpu, making cpu > self-sufficient in this regard. Later it will allow to cleanup hw/pc.c > and remove cpu_reset and wrappers from there. > - stores flag that CPU is BSP in IA32_APIC_BASE to model behavior > described in Inted SDM vol 3a part 1 chapter 8.4.1 > - uses MSR_IA32_APICBASE_BSP flag in apic_base for checking if cpu is BSP > > patch is based on Jan Kiszka's proposal: > http://thread.gmane.org/gmane.comp.emulators.qemu/100806
This patch has a summary (subject) line that is way too long: it should be short enough to fit reasonably on one line. > v2: > - fix build for i386-linux-user > spotted-by: Peter Maydell <peter.mayd...@linaro.org> > v3: > - style change requested by Andreas Färber <afaer...@suse.de> > > v4: > - reuse cpu_is_bsp() rather than open code check if apicbase has BSP bit set > requested by Gleb Natapov <g...@redhat.com> > - hijacked Andreas' patch [1] to use X86CPU instead of CPUX86State in > cpu_is_bsp() > > 1) http://lists.gnu.org/archive/html/qemu-devel/2012-05/msg03185.html It's usual to put between-patchver changes below the '---' line. -- PMM