Markus Armbruster <arm...@redhat.com> writes: > Wanpeng Li <liw...@linux.vnet.ibm.com> writes: > >> [CCing ML] >> >> From: Anthony Liguori <aligu...@us.ibm.com> >> >> The HPET usually sits on the LPC bus (which replaces ISA in modern systems). >> It's sometimes a dedicated chip but can certain co-exist in a Super IO chip. >> I think in terms of where it would live in this hypothetical device model, >> putting it in the PIIX is rational. > > Could you explain briefly why you have to move struct definitions from > .c to .h?
This patch shouldn't be in this series. The reason to do this is so that the PIIX3 can do composition and have the HPET/PIT as child devices. But that isn't in this series so having this patch isn't useful. Regards, Anthony Liguori