On 07/25/2012 06:21 AM, Stefan Hajnoczi wrote: > This tests establishes the basic post-conditions of the qcow2 lazy > refcounts features: > > 1. If the image was closed normally, it is marked clean. > > 2. If an allocating write was performed and the image was not close > normally, then it is marked dirty. > > a. Written data can be read back successfully. > b. The image file can be repaired and will be marked clean again. > > Signed-off-by: Stefan Hajnoczi <stefa...@linux.vnet.ibm.com>
> +++ b/tests/qemu-iotests/039 > @@ -0,0 +1,117 @@ > +#!/bin/bash Since you are assuming bash (and even if you were to assume POSIX /bin/sh)... > + > +seq=`basename $0` I prefer $() over ``. > +echo "QA output created by $seq" > + > +here=`pwd` POSIX (and therefore bash) guarantees that $PWD is sane, and faster to access than $(pwd). > +tmp=/tmp/$$ That's not very secure. It may be worth using bash's $RANDOM, or using mkstemp(1). Beyond that, the series seemed reasonable to me. -- Eric Blake ebl...@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
