Il 03/09/2012 18:15, Avi Kivity ha scritto:
>> > The values above are what every user of the PIC cascaded on our targets
>> > must program to use them. So We will find them in the state once any
>> > relevant guest code was able to run (e.g. the BIOS).
>> > 
> Suppose the bios has not run yet?

Then you transmit the subsection.

BTW this also means that simply checking against eclr|icw3 is wrong; the
right test is:

* against elcr if !s->master

* against elcr|icw3 if s->master

This makes precomputing the value more appealing.

Similarly, perhaps this:

    if (s->special_fully_nested_mode && s->master) {
        mask &= ~(1 << 2);
    }

should be changed to

    if (s->special_fully_nested_mode && s->master) {
        mask &= ~s->icw3;
    }

?

Paolo

Reply via email to