On 09/24/2012 12:07 PM, Paolo Bonzini wrote: > Il 24/09/2012 11:53, Markus Armbruster ha scritto: >> ongoing >> >>>> + * @errp: set in case of an error >>>> + **/ >> We usually tack function comments to the function definition, not the >> declaration. Matter of taste. I like it next to the definition, >> because that improves the comment's chances to get updated along with >> the function. > > Not necessarily, see main-loop.h for example. > > /me would like more of these... too late :) > > Paolo > >>>> +int inet_connect_opts(QemuOpts *opts, bool block, bool *in_progress, >>>> + Error **errp); >
- [Qemu-devel] [PATCH v4 0/4] nonblocking connect address ... Orit Wasserman
- [Qemu-devel] [PATCH v4 1/4] Refactor inet_connect_o... Orit Wasserman
- [Qemu-devel] [PATCH v4 2/4] Separate inet_connect i... Orit Wasserman
- Re: [Qemu-devel] [PATCH v4 2/4] Separate inet_c... Markus Armbruster
- Re: [Qemu-devel] [PATCH v4 2/4] Separate in... Paolo Bonzini
- Re: [Qemu-devel] [PATCH v4 2/4] Separat... Orit Wasserman
- Re: [Qemu-devel] [PATCH v4 2/4] Se... Paolo Bonzini
- [Qemu-devel] [PATCH v4 3/4] Fix address handling in... Orit Wasserman
- Re: [Qemu-devel] [PATCH v4 3/4] Fix address han... Markus Armbruster
- Re: [Qemu-devel] [PATCH v4 3/4] Fix address han... Orit Wasserman
- Re: [Qemu-devel] [PATCH v4 3/4] Fix address han... Amos Kong
- Re: [Qemu-devel] [PATCH v4 3/4] Fix address... Orit Wasserman
- [Qemu-devel] [PATCH v4 4/4] Clear handler only for ... Orit Wasserman
- Re: [Qemu-devel] [PATCH v4 4/4] Clear handler o... Markus Armbruster
- Re: [Qemu-devel] [PATCH v4 4/4] Clear handl... Orit Wasserman
- Re: [Qemu-devel] [PATCH v4 4/4] Clear h... Paolo Bonzini