Orit Wasserman <owass...@redhat.com> wrote: > On 09/21/2012 11:47 AM, Juan Quintela wrote: >> It always have that type, just change it. >> -QEMUFile *qemu_fopen_ops_buffered(void *opaque, size_t xfer_limit, >> +QEMUFile *qemu_fopen_ops_buffered(MigrationState *migration_state, >> + size_t xfer_limit, >> BufferedPutFunc *put_buffer, >> BufferedPutReadyFunc *put_ready, >> BufferedWaitForUnfreezeFunc >> *wait_for_unfreeze, >> > Again why ? this is a general buffered file not just for migration use.
It is not used for anything else. It is used only, and inlining it removes one level of indirection. All wins on my book. Notice that once the migration-thread patches end, this file basically dissapears (its only reason to exist was to allow non-blocking writes"). Later, Juan.
