On 19.11.2012, at 14:35, Eduardo Habkost wrote: > On Mon, Nov 19, 2012 at 02:14:27PM +0100, Alexander Graf wrote: >> >> On 13.11.2012, at 13:11, Christian Borntraeger wrote: >> >>> From: Heinz Graalfs <graa...@linux.vnet.ibm.com> >>> >>> The global variable 'ram_size' is hidden by the local variable >>> declaration in s390_init() >> >> That's the point of Eduardo's patch, no? Or do we need access to the global >> to change its value afterwards? If so, please write a reasonable patch >> description that actually explains the problem. >> > > Actually, I wanted to keep the existing behavior (whatever it was), and > use local variables to replace the old function parameters, and change > nothing else. Most machines used a local variable named 'ram_size', but > the parameter to s390_init() was named 'my_ram_size'. > > So, considering that this at least restores the previous behavior: > > Reviewed-by: Eduardo Habkost <ehabk...@redhat.com>
Yup, Heinz, please resend with a patch description that actually tells us what the problem is. Alex
