Hi, >> -static CharDriverState *qemu_chr_open_socket(QemuOpts *opts) >> +static CharDriverState *qemu_chr_open_socket_fd(int fd, int >> do_nodelay, + int >> is_listen, int is_telnet, + >> int is_waitconnect, > > These three parameters sound like they might be better as 'bool' > instead of 'int'.
Just continuing to do what the existing code did. >> @@ -2458,10 +2536,7 @@ static CharDriverState >> *qemu_chr_open_socket(QemuOpts *opts) if (!is_listen) >> is_waitconnect = 0; >> >> - chr = g_malloc0(sizeof(CharDriverState)); - s = >> g_malloc0(sizeof(TCPCharDriver)); - - if (is_unix) { + if >> (is_unix) { > > Spurious re-indentation? Seems so, I'll check. cheers, Gerd