Il 10/01/2013 11:53, Gerd Hoffmann ha scritto: >> > >> > This ought to use qmp_chardev_add and a generic opts->ChardevBackend >> > conversion. >> > >> > But IMHO, this kind of intermediate conversion is okay, with the >> > "correct" thing deferred; being able to play with hotplug from HMP is >> > worth the small wart. It's really Luiz's decision, so I'm not giving >> > the reviewed-by (yet). > Once qmp_chardev_add() can handle everything supported by > qemu_chr_new_from_opts we can flip over, make qmp_chardev_add the > primary interface and qemu_chr_new_from_opts legacy (which then does the > opts->ChardevBackend conversion and calls qmp_chardev_add). > > We are not there yet, even with the full series applied.
Yup. Strange ones like msmouse, braille, etc. are missing. > And even when we arrive there some day we don't have to touch > hmp_chardev_add when making the switch ;) Indeed. Paolo
