On 01/10/2013 07:23 AM, Gerd Hoffmann wrote:
> Add support for file chardevs. Output file is mandatory,
> input file is optional.
>
> Signed-off-by: Gerd Hoffmann <kra...@redhat.com>
> ---
> qapi-schema.json | 13 ++++++++++-
> qemu-char.c | 61
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> qmp-commands.hx | 8 ++++++-
> 3 files changed, 80 insertions(+), 2 deletions(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 53d4b9e..7930139 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -3019,6 +3019,16 @@
> { 'command': 'nbd-server-stop' }
>
> ##
> +# @ChardevFile:
Should you mention '@in: #optional' and '@out:' in any further detail?
> +#
> +# Configuration info for file chardevs.
> +#
> +# Since: 1.4
> +##
> +{ 'type': 'ChardevFile', 'data': { '*in' : 'str',
> + 'out' : 'str' } }
Hmm; here you document ChardevFile as a separate type, but you didn't
document ChardevDummy in patch 4/10.
> +#ifdef _WIN32
> +
> +#else /* WIN32 */
Wouldn't this be /* !_WIN32 */?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
