That would only mean that the monitor was suffering from the same problem before the patch, since the keys that were supported before were already layout-specific.
The patch does not intend to change the way the monitor works and improve its localization and internationalization support, just to extend existing functionalities. More keys were added to the monitor using the layout that the existing keys were using. Indeed, in the future it would be nice to have multiple keyboard layout support, which is indeed lacking right now, but for now, the monitor does not supply support for this, and was simply lacking many keys in what it does support, which is a much bigger problem. So this patch is a step in the right direction. This is as far as specific keys are concerned, The "sendstring" addition seems to be just an important thing to have, and it is a bit useless with that many keys missing anyway. -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Samuel Thibault Sent: Monday, December 31, 2007 7:45 PM To: qemu-devel@nongnu.org Subject: Re: [Qemu-devel] [PATCH] qemu monitor keyboard functionality Noam Taich, le Mon 31 Dec 2007 09:02:08 -0800, a écrit : > Qemu monitor had many missing keys that could not be (easily) sent, > > And there was no mechanism for sending strings properly. > > This patch fixes the problem and enhances the monitor's functionality. Mmm, isn't there a keyboard layout issue? Far from all keyboards are US qwerty... Samuel
