Hi, Thank you for submitting your patch series. checkpatch.pl has detected that one or more of the patches in this series violate the QEMU coding style.
If you believe this message was sent in error, please ignore it or respond here with an explanation. Otherwise, please correct the coding style issues and resubmit a new version of the patch. For more information about QEMU coding style, see: http://git.qemu.org/?p=qemu.git;a=blob_plain;f=CODING_STYLE;hb=HEAD Here is the output from checkpatch.pl: Subject: target-i386: Implement tzcnt and fix lzcnt Subject: target-i386: Simplify bsf/bsr flags computation Subject: target-i386: Use clz/ctz for bsf/bsr helpers Subject: target-i386: Implement ADX extension WARNING: braces {} are necessary for all arms of this statement #221: FILE: target-i386/translate.c:4247: + if (ot == OT_LONG) { [...] + } else [...] total: 0 errors, 1 warnings, 213 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Subject: target-i386: Implement RORX Subject: target-i386: Implement SHLX, SARX, SHRX Subject: target-i386: Implement PDEP, PEXT Subject: target-i386: Implement MULX WARNING: braces {} are necessary for all arms of this statement #55: FILE: target-i386/translate.c:4111: + if (s->dflag == 2) { [...] + } else [...] total: 0 errors, 1 warnings, 62 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Subject: target-i386: Implement BZHI Subject: target-i386: Implement BLSR, BLSMSK, BLSI Subject: target-i386: Implement BEXTR Subject: target-i386: Implement ANDN Subject: target-i386: Implement MOVBE Subject: target-i386: Decode the VEX prefixes Subject: target-i386: Tidy prefix parsing Subject: target-i386: Make helper_cc_compute_all const Subject: target-i386: Don't reference ENV through most of cc helpers Subject: target-i386: Use CC_SRC2 for ADC and SBB Subject: target-i386: optimize flags checking after sub using CC_SRC2 Subject: target-i386: Update cc_op before TCG branches Subject: target-i386: introduce gen_jcc1_noeob Subject: target-i386: use gen_op for cmps/scas Subject: target-i386: kill cpu_T3 Subject: target-i386: expand cmov via movcond Subject: target-i386: introduce gen_cmovcc1 WARNING: braces {} are necessary for all arms of this statement #34: FILE: target-i386/translate.c:2428: + if (ot == OT_LONG) { [...] + } else [...] total: 0 errors, 1 warnings, 82 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Subject: target-i386: cleanup temporary macros for CCPrepare Subject: target-i386: inline gen_prepare_cc_slow Subject: target-i386: use CCPrepare to generate conditional jumps Subject: target-i386: introduce gen_prepare_cc Subject: target-i386: introduce CCPrepare Subject: target-i386: optimize setcc instructions Subject: target-i386: optimize setle Subject: target-i386: optimize setbe Subject: target-i386: change gen_setcc_slow_T0 to gen_setcc_slow Subject: target-i386: convert gen_compute_eflags_c to TCG Subject: target-i386: use inverted setcond when computing NS or NZ Subject: target-i386: do not call helper to compute ZF/SF Subject: target-i386: Move CC discards to set_cc_op Subject: target-i386: no need to flush out cc_op before gen_eob Subject: target-i386: do not compute eflags multiple times consecutively Subject: target-i386: add helper functions to get other flags Subject: target-i386: Use gen_update_cc_op everywhere Subject: target-i386: Don't clobber s->cc_op in gen_update_cc_op Subject: target-i386: Introduce set_cc_op Subject: target-i386: Name the cc_op enumeration Subject: target-i386: factor gen_op_set_cc_op/tcg_gen_discard_tl around computing flags Subject: target-i386: use gen_jcc1 to compile loopz Subject: target-i386: clean up sahf Subject: target-i386: compute eflags outside rcl/rcr helper Subject: target-i386: move eflags computation closer to gen_op_set_cc_op Subject: target-i386: move carry computation for inc/dec closer to gen_op_set_cc_op Subject: target-i386: drop cc_op argument of gen_jcc1 Subject: target-i386: factor setting of s->cc_op handling for string functions Subject: target-i386: introduce gen_ext_tl Subject: target-i386: use OT_* consistently Subject: test-i386: make it compile with a recent gcc Subject: test-i386: QEMU_PACKED is not defined here Regards, Anthony Liguori
