On 03/22/2013 07:16 AM, Pavel Hrdina wrote: > HMP command "savevm" now takes extra optional force parameter to specify > whether > replace existing snapshot or not. > > QMP command "vm-snapshot-save" has also extra optional force parameter and > name parameter isn't optional anymore.
Again, my question from 7/12 - why not rebase this series to implement
QMP correctly from the getgo, and have this patch be JUST an HMP
addition to expose the new QMP capability?
>
> Signed-off-by: Pavel Hrdina <phrd...@redhat.com>
> ---
> hmp-commands.hx | 15 ++++++++-------
> hmp.c | 3 ++-
> qapi-schema.json | 7 +++++--
> qmp-commands.hx | 16 ++++++++++------
> savevm.c | 25 ++++++++++++++++---------
> 5 files changed, 41 insertions(+), 25 deletions(-)
>
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index 3c1cb05..bfe0645 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -307,18 +307,19 @@ ETEXI
>
> {
> .name = "savevm",
> - .args_type = "name:s?",
> - .params = "[tag|id]",
> - .help = "save a VM snapshot. If no tag or id are provided, a
> new snapshot is created",
> + .args_type = "force:-f,name:s?",
> + .params = "[-f] [tag|id]",
> + .help = "save a VM snapshot. To replace existing snapshot use
> force flag.",
Not an error message, so I'm not duplicating myself :)
Prevailing convention seems to be omitting trailing '.' in .help messages.
> .mhandler.cmd = hmp_vm_snapshot_save,
> },
>
> STEXI
> -@item savevm [@var{tag}|@var{id}]
> +@item savevm [@var{-f}] @var{tag}|@var{id}
> @findex savevm
> -Create a snapshot of the whole virtual machine. If @var{tag} is
> -provided, it is used as human readable identifier. If there is already
> -a snapshot with the same @var{tag} or @var{id}, it is replaced. More info at
> +Create a snapshot of the whole virtual machine. Parameter "name" is optional.
> +If @var{tag} is provided, it is used as human readable identifier. If there
> is
> +already a snapshot with the same @var{tag} or @var{id}, @var{-f} flag needs
> to
> +be specified. More info at @ref{vm_snapshots}.
> @ref{vm_snapshots}.
@ref{vm_snapshots} now appears twice in the output.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
