Am 27.03.2013 13:12, schrieb Igor Mammedov: > On Wed, 27 Mar 2013 12:01:20 +0100 > Paolo Bonzini <pbonz...@redhat.com> wrote: > >> Il 21/03/2013 15:28, Igor Mammedov ha scritto: >>> diff --git a/target-i386/cpu.c b/target-i386/cpu.c >>> index d03ff73..631bcd8 100644 >>> --- a/target-i386/cpu.c >>> +++ b/target-i386/cpu.c >>> @@ -2260,6 +2260,11 @@ out: >>> error_propagate(errp, local_err); >>> return; >>> } >>> + >>> + if (dev->hotplugged) { >>> + cpu_synchronize_post_init(env); >>> + resume_vcpu(CPU(cpu)); >>> + } >> >> I think the resume_vcpu should not be here, but in the superclass. > > Then I should move following parts to superclass: > > if (dev->hotplugged) { > cpu_synchronize_post_init(env); > resume_vcpu(CPU(cpu)); > } > > because in case of KVM we should make sure that CPU in sane state before > allowing CPU to become run-able.
That's not possible until we change cpu_synchronize_post_init() argument to CPUState, which is somewhere down my TODO list. Currently I have mostly flushed my refactorings out, so if you wanted to dive into that, that would be appreciated. :) Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg