Il 27/03/2013 16:16, Igor Mammedov ha scritto: > yep, I re-factored every *cpu_synchronize_post*() call, > > but considering an intention to call cpu_synchronize_post_init() from > qom/cpu.c this patch won't work nice since it will pull with itself > kvm-stub.o to *-user target. > > Due to qom/cpu.c is built only once for both softmmu and *-user targets, I > consider to move cpu_synchronize_post_init() & cpu_synchronize_post_reset() > from include/sysemu/kvm.h into include/sysemu/cpus.h with definition moved > into cpus.c + stubs for cpu_synchronize_post_init() &resume_vcpu() in > libqemustub for *-user target. > Adding stubs to libqemustub could be avoided if resume_vcpu() and > cpu_synchronize_post_init() are called from x86_cpu_realizefn() > at the cost of some ifdeffenery in include/sysemu/cpus.h though. > > But moving resume_vcpu() & cpu_synchronize_post_init() into qom/cpu.c looks > like good candidate for being reused by other targets. > > Paolo, > would it be acceptable to add resume_vcpu() & cpu_synchronize_post_init() > stubs into libqemustub?
Can you instead add all of kvm-stub.c? Paolo
