Am 05.04.2013 16:36, schrieb Igor Mammedov: > When APIC is hotplugged during CPU hotplug, device_set_realized() > calls device_reset() on it. And if QEMU runs in KVM mode, following > call chain will fail: > apic_reset_common() > -> kvm_apic_vapic_base_update() > -> kvm_vcpu_ioctl(cpu->kvm_fd,...) > due to cpu->kvm_fd not being initialized yet. > > cpu->kvm_fd is initialized during qemu_init_vcpu() call but > x86_cpu_apic_init() > can't be moved after it because kvm_init_vcpu() -> kvm_arch_reset_vcpu() > relies on APIC to determine if CPU is BSP for setting initial env->mp_state. > > So split APIC device creation from its initialization and realize APIC > after CPU is created, when it's safe to call APIC's reset method. > > Signed-off-by: Igor Mammedov <imamm...@redhat.com> > --- > v2: > * s/x86_cpu_apic_init()/x86_cpu_apic_realize()/
Thanks, applied to qom-cpu (dropping "call" from commit message to squeeze it into 76 chars): https://github.com/afaerber/qemu-cpu/commits/qom-cpu Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
