On Thu, May 23, 2013 at 04:47:13PM +0800, Wenchao Xia wrote: > -int bdrv_is_snapshot(BlockDriverState *bs) > -{ > - return !!(bs->open_flags & BDRV_O_SNAPSHOT); > -}
No need to respin, but this function has nothing to do with the other functions. This function is about -drive snapshot=on, the others are about internal snapshots. It should not go into block/snapshot.c. At least it should be documented as having nothing to do with internal snapshots. Stefan