On 24 May 2013 14:33, Paolo Bonzini <pbonz...@redhat.com> wrote: > Il 24/05/2013 15:27, Peter Maydell ha scritto: >> On 24 May 2013 13:58, Paolo Bonzini <pbonz...@redhat.com> wrote: >>> If it's okay >>> for you, I'll send a pull request up to "memory: clean up phys_page_find" >>> and go on with the next series. >> >> That's fine with me, but please don't forget to fix up >> the doc comment for memory_region_find() (see comments on >> patch 6/30). You can do that in a patch in the next series, >> though, I guess. > > What about this: > > /** > * memory_region_find: translate an address/size relative to a > * MemoryRegion into a #MemoryRegionSection. > * > * Locates the first #MemoryRegion within @mr that overlaps the range > * given by @addr and @size. > * > * Returns a #MemoryRegionSection that describes a contiguous overlap. > * It will have the following characteristics: > * .@size = 0 iff no overlap was found > * .@mr is non-%NULL iff an overlap was found > * > * Remember that in the return value the @offset_within_region is > * relative to the returned region (in the .@mr field), not to the > * @mr argument. > * > * Similarly, the .@offset_within_address_space is relative to the > * address space that contains both regions, the passed and the > * returned one. However, in the special case where the @mr argument > * has no parent (and thus is the root of the address space), the > * following will hold: > * .@offset_within_address_space >= @addr > * .@offset_within_address_space + .@size <= @addr + @size > * > * @mr: a MemoryRegion within which @addr is a relative address > * @addr: start of the area within @as to be searched > * @size: size of the area to be searched > */
Yes, that looks OK to me. thanks -- PMM
