Am 25.05.2013 11:28, schrieb Michael Tokarev: > 24.05.2013 06:47, liguang wrote: >> when enable DEBUG_DEBUGCON, there are some message >> printing bugs, so fix them. >> >> this patch-set based on previous 3 patches, >> http://comments.gmane.org/gmane.comp.emulators.qemu/212550 >> http://comments.gmane.org/gmane.comp.emulators.qemu/212551 >> http://comments.gmane.org/gmane.comp.emulators.qemu/212552 >> >> cover-letter and patch [4/4] are new, no changes >> for other 3. >> >> Li Guang (4) >> debugcon: fix always print "addr=0x0, val=0x0" bug when use >> DEBUG_DEBUGCON >> debugcon: make debug message more readable >> debugcon: fix compiler warning when open DEBUG_DEBUGCON >> debugcon: use fprintf(stderr...) instead of printf > > The subjects and commit messages are a bit inaccurate, and > as Andreas says, these may have been merged together, but > the inaccuracy is small (and mostly due to language barriers), > and the result is good anyway, with one patch doing one thing. > > So.. thanks, applied to the trivial-patches queue.
NACK. If you want to apply 1-3, okay. But please unqueue 4/4, it makes no sense as-is (just look at the stderr output to see what I mean) and it pretends that I suggested that! Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
