After discussion off-list, I've gone back and retested versions 4, 5, and 6 of this patch.
I'm using the test script previously attached. I'm using libguestfs (ada94eb9) & curl (ba9a6666) & qemu (6a4e177114) all the latest from git. I'm using a 6 GB Windows XP guest. The web server is remote, over quite slow wifi, and is running Apache 2.2.15 on RHEL 6. I ran each test 3 times. v4: Buffer I/O errors reported inside the appliance on each run. No segfault in qemu. v5: Buffer I/O errors reported inside the appliance on each run. No segfault in qemu. v6: Buffer I/O errors reported inside the appliance on each run. No segfault in qemu. no patch (curl driver in upstream qemu): No errors. Everything works. -- So I guess what has happened is NOT a regression from v5 -> v6, but that something has changed in my environment which has stopped this patch from working. I'm continuing to investigate. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v