On 06/29/2013 01:01 PM, Andreas Färber wrote:
> if ((env->cr[0] & CR0_PE_MASK)) {
> + X86CPU *cpu = x86_env_get_cpu(env);
> static int count;
>
> qemu_log("%6d: v=%02x e=%04x i=%d cpl=%d IP=%04x:" TARGET_FMT_lx
> @@ -1180,7 +1181,7 @@ static void do_interrupt_all(CPUX86State *env, int
> intno, int is_int,
> qemu_log(" env->regs[R_EAX]=" TARGET_FMT_lx,
> env->regs[R_EAX]);
> }
> qemu_log("\n");
> - log_cpu_state(env, CPU_DUMP_CCOP);
> + log_cpu_state(CPU(cpu), CPU_DUMP_CCOP);
Not a bug, but I'd like to know your rationale for adding X86CPU *cpu variables
as opposed to CPUState *cs variables? Especially when the cpu variable is
never used without the cast to CPU.
Otherwise,
Reviewed-by: Richard Henderson <r...@twiddle.net>
r~
