On 4 July 2013 16:03, Markus Armbruster <arm...@redhat.com> wrote: > Peter Maydell <peter.mayd...@linaro.org> writes: >> This looks a bit odd -- why are we creating new >> options in a function that claims to only be querying >> them? > > So we never return null. If it bothers you, I can initialize the > options to empty somewhere else, and assert they exist here.
The other option would be to modify qemu_opt_get and friends to accept a NULL QemuOpts* as meaning "return the default". That seems cleaner to me than having "machine" opts be a special case. -- PMM
