On 07/08/13 21:00, Luiz Capitulino wrote:
> On Mon, 8 Jul 2013 18:47:24 +0000
> Seiji Aguchi <seiji.agu...@hds.com> wrote:
>
>>>> +DEF("msg", HAS_ARG, QEMU_OPTION_msg,
>>>> + "-msg timestamp[=on|off]\n"
>>>> + " change the format of messages\n"
>>>> + " on|off controls leading timestamps (default:on)\n",
>>>
>>> Did you really intend to say it's on by default? Because it's actually
>>> disabled by default. I prefer having this disabled btw, and I can fix it
>>> myself before applying if that's what you intended.
>>
>>
>> My default is "-msg timestamp".
>> Why do you think it is actually disabled by default?
>
> Oh, for some reason I assumed you wanted the timestamps to show up
> even when -msg is not passed. But now I see that it's on by default
> only if -msg timestamp is passed. Seems reasonable.
Yeah the "(default: XXX)" statements in "qemu-options.hx" keep confusing
me too. They don't document the default qemu behavior (ie. with the
option absent) but the default behavior of the specific option, if given
on the command line :)
> Applied to the qmp branch, thanks.
Great, thanks!
In case you're willing to reword the commit message:
Reviewed-by: Laszlo Ersek <ler...@redhat.com>
Laszlo
