On 07/09/2013 06:04 AM, Kevin Wolf wrote: >> and these still duplication of those comments for type declaration? > > No, the DriveBackup documentation doesn't describe what the command does > or what it returns. You might argue that it should be there, but I think > that's out of scope for this patch and you can do it separately if you > like.
Besides, the DriveBackup type is usable within the 'transaction' command, where it does NOT have an associated return type (it is just one of many actions, where ALL actions have no return, and the overall 'transaction' command either succeeds or fails). I don't think any separate patch is warranted here, unless you also make the same arguments for 'blockdev-snapshot-sync'. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
