Am 09.07.2013 um 14:09 hat Eric Blake geschrieben: > On 07/09/2013 06:04 AM, Kevin Wolf wrote: > >> and these still duplication of those comments for type declaration? > > > > No, the DriveBackup documentation doesn't describe what the command does > > or what it returns. You might argue that it should be there, but I think > > that's out of scope for this patch and you can do it separately if you > > like. > > Besides, the DriveBackup type is usable within the 'transaction' > command, where it does NOT have an associated return type (it is just > one of many actions, where ALL actions have no return, and the overall > 'transaction' command either succeeds or fails). I don't think any > separate patch is warranted here, unless you also make the same > arguments for 'blockdev-snapshot-sync'.
Ah, right, I forgot about this. So the return type should stay where it is. What you still could move is the command description ("Start a point-in-time copy [...]") because that one applies to the transaction command as well. Kevin