On Sun, 28 Jul 2013 19:24:03 +0200 Andreas Färber <afaer...@suse.de> wrote:
> Am 28.07.2013 19:21, schrieb Igor Mammedov: > > On Sun, 28 Jul 2013 11:57:14 +0200 > > Andreas Färber <afaer...@suse.de> wrote: > > > >> Am 28.07.2013 09:29, schrieb Igor Mammedov: > >>> Signed-off-by: Igor Mammedov <imamm...@redhat.com> > >>> --- > >>> hw/pci-host/piix.c | 8 ++++++-- > >>> 1 file changed, 6 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c > >>> index 3908860..bf879e7 100644 > >>> --- a/hw/pci-host/piix.c > >>> +++ b/hw/pci-host/piix.c > >>> @@ -38,6 +38,10 @@ > >>> * http://download.intel.com/design/chipsets/datashts/29054901.pdf > >>> */ > >>> > >>> +#define TYPE_I440FX_PCI_HOST "i440FX-pcihost" > >>> +#define I440FX_PCI_HOST(obj) \ > >>> + OBJECT_CHECK(I440FXState, (obj), TYPE_I440FX_PCI_HOST) > >> > >> Either Anthony or mst had insisted on PCI_HOST_BRIDGE rather than > >> PCI_HOST. Other than that looks good, thanks! > > > > it's the type cast macro that is missing, so adding it shouldn't hurt, > > and some day in future we might any way need to add it even if we don't use > > it > > now. > > Maybe you misunderstood? Please add _BRIDGE to your macros. :) Yep, sure I'll do it. > > Andreas > > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -- Regards, Igor
